Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeaVM Impl #262

Merged
merged 17 commits into from
Jul 10, 2024
Merged

TeaVM Impl #262

merged 17 commits into from
Jul 10, 2024

Conversation

rosstroha
Copy link
Contributor

Support for TeaVM JS Transpiling.

Many of the changes are related to the regexes. TeaVM does not support named groups, so the groups had to be switched to integer based references.

Copy link
Member

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see a test along the lines of, a JS file which imports the resulting JS, runs the exported methods against a sample policy, and asserts on the resulting strings.

(This will require adding the setup-node action, which can hardcode 20 rather than bothering testing against multiple versions.)

pom.xml Show resolved Hide resolved
src/main/java/com/shapesecurity/salvation2/Salvation2.java Outdated Show resolved Hide resolved
@rosstroha
Copy link
Contributor Author

rosstroha commented Feb 16, 2024

Would like to see a test along the lines of, a JS file which imports the resulting JS, runs the exported methods against a sample policy, and asserts on the resulting strings.

(This will require adding the setup-node action, which can hardcode 20 rather than bothering testing against multiple versions.)

@bakkot What if I did this as part of the csp validator website? I think someone mentioned combing the repositories so it might make sense to do that in the JS ecosystem instead of having to implement something here.

pom.xml Outdated Show resolved Hide resolved
src/main/java/com/shapesecurity/salvation2/Salvation2.java Outdated Show resolved Hide resolved
src/test/javascript/salvation.test.js Show resolved Hide resolved
src/test/javascript/salvation.test.js Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@rosstroha
Copy link
Contributor Author

:shipit:

@disnet disnet merged commit 2c4d7c9 into shapesecurity:main Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants